Review Request 125371: Added argument-hint code completion

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125371/#review85909
-----------------------------------------------------------

Ship it!


Minor thing, please push! I'm willing to implement the arcane code required for getting the current position marked, btw.

Thanks so much for this patch, I was about to start working on a string parser for function arguments b/c I did not know we could query the required data via clang after all! awesomeness Sergey, pure awesomeness!


codecompletion/context.cpp (line 887)
<https://git.reviewboard.kde.org/r/125371/#comment59298>

    the usage of the macro so many times is ugly, but I also don't see an easy way of changing that. ah well, that's live



tests/test_codecompletion.cpp (line 942)
<https://git.reviewboard.kde.org/r/125371/#comment59297>

    replace with
    
    QSKIP(CINDEX_VERSION_MINOR < 30);


- Milian Wolff


On Sept. 24, 2015, 9:31 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125371/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 9:31 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Now we show a separate list with argument-hint items.
>     
> E.g. "function(|"
> At | the "function" is added to the argument-hint list
>     
> There are still some issues, like:
> -no declaration found for argument-hint items
> -default parameters not supported yet
> -the current parameter is not market out
> -and probably other
>     
> But, they are not so important, and most of them can be fixed later on.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 9622ebd 
>   tests/test_codecompletion.h 8c5b607 
>   tests/test_codecompletion.cpp a4e8fb6 
> 
> Diff: https://git.reviewboard.kde.org/r/125371/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> argument_hint1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/24/6c9a3447-4d50-45e6-9831-23680ea9e391__argument_hint1.png
> argument_hint2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/24/f81f6ddf-46bd-42d3-85ac-171d7fa74596__argument_hint2.png
> argument_hint3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/24/084631c3-b298-4e6f-aa50-c394f9647aab__argument_hint3.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150925/4461ef01/attachment.html>