Review Request 125301: Don't show explicitly deleted/default functions in implements completion

[Sergey Kalinichev]

> On Sept. 23, 2015, 1:17 a.m., Alex Richardson wrote:
> > I've fixed all the raised issues locally, just not sure whether I should de-inline the functions or not?
> > As they are all just trivial one line functions inlining them probably even reduces the code size compared to a funtion call.
> > Also we are using the clang-c API anyway so there is no need to hide its usage in a separate file.

The performance gain and the compiled code size should be negligible.

Disadvantages I see:
* Changing the implementation of the inlined function, you need to recompile all files that use that header.
* It slightly increases compile time
* It makes the header file larger
* It dilutes important information (class members) with unimportant implementation details.

So, I don't really see any advantages of inlining functions here...


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125301/#review85790
-----------------------------------------------------------


On Sept. 19, 2015, 9:38 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125301/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2015, 9:38 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> REVIEW: 125301
> 
> 
> Diffs
> -----
> 
>   codecompletion/completionhelper.cpp df5712bb31dfa39e99a593367036d42dc41701d1 
>   codecompletion/context.cpp 995b4b04157be9658e651c1680f3c0222cb0d8b0 
>   duchain/clangproblem.cpp bd5a20105c1c3769791f75389afbdc93a5b9c193 
>   duchain/todoextractor.cpp 764fbd251e028df85844f98ca851a4422406d163 
>   tests/clang-parser.cpp 27b4eb535f3f47e84a495daaa60862257170f1fa 
>   tests/test_codecompletion.cpp a2ed37f55995a8d224512d59b187dba1a80ed446 
>   util/clangtypes.h 1913e444ff021b5ba3fc4a5cf555ed19e4460646 
>   util/clangutils.h af80b906eb1ca466f110c8c12637568ab1a52fc4 
>   util/clangutils.cpp 506dfdeeeccf4d665a53d0b1ebaaa608a7ec9cb5 
> 
> Diff: https://git.reviewboard.kde.org/r/125301/diff/
> 
> 
> Testing
> -------
> 
> Tests pass except for the global deleted function.
> 
> Not sure how to fix this as it seems like clang_getCursorExtent(declCursor) is wrong in that case. Or maybe I need to calaculate the range differently?
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150923/bb52f4d2/attachment.html>