Review Request 125305: Fix '.' to '->' member access replacement

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125305/#review85707
-----------------------------------------------------------

Ship it!


minor stuff, otherwise looks good to me - thanks!


codecompletion/context.cpp (line 657)
<https://git.reviewboard.kde.org/r/125305/#comment59224>

    use QLatin1String here instead please



codecompletion/context.cpp (line 735)
<https://git.reviewboard.kde.org/r/125305/#comment59225>

    please trim it only once, you do it three times here, creating up to three temporary allocations


- Milian Wolff


On Sept. 19, 2015, 7:35 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125305/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2015, 7:35 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Clang doesn't provide diagnostic for it. So let't try to manually determine whether this is the case, this is not so hard after all.
>     
> This also means that now we use clang_codeCompleteAt twice, but it doesn't matter much here as the input is already invalid, hence no completion items.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.h 827e044 
>   codecompletion/context.cpp 995b4b0 
>   codecompletion/model.cpp 2442e38 
>   tests/test_codecompletion.cpp a2ed37f 
> 
> Diff: https://git.reviewboard.kde.org/r/125305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150921/f0745e67/attachment-0001.html>