Review Request 125301: Don't show explicitly deleted/default functions in implements completion

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125301/#review85706
-----------------------------------------------------------

Ship it!


some minor things, in general this looks really good already. Many thanks!


codecompletion/context.cpp (line 330)
<https://git.reviewboard.kde.org/r/125301/#comment59218>

    const?



duchain/clangproblem.cpp (line 135)
<https://git.reviewboard.kde.org/r/125301/#comment59217>

    const?



tests/test_codecompletion.cpp (line 112)
<https://git.reviewboard.kde.org/r/125301/#comment59219>

    I'd rather you remove this, or add it everywhere.  don't think it's too helpful, really.
    
    You could also simplify it by simply asking for the clang support plugin by it's ID and asserting that it's available.



util/clangtypes.h (line 119)
<https://git.reviewboard.kde.org/r/125301/#comment59220>

    +1 to that



util/clangutils.h (line 117)
<https://git.reviewboard.kde.org/r/125301/#comment59221>

    remove empty lines please



util/clangutils.cpp (line 297)
<https://git.reviewboard.kde.org/r/125301/#comment59222>

    maybe add a `bool operator==(const char*) const` to ClangString for this purpose to simplify the code here and below?



util/clangutils.cpp (line 319)
<https://git.reviewboard.kde.org/r/125301/#comment59223>

    remove this, that way we get a compile warning when new stuff gets added.


- Milian Wolff


On Sept. 19, 2015, 6:38 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125301/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2015, 6:38 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> REVIEW: 125301
> 
> 
> Diffs
> -----
> 
>   codecompletion/completionhelper.cpp df5712bb31dfa39e99a593367036d42dc41701d1 
>   codecompletion/context.cpp 995b4b04157be9658e651c1680f3c0222cb0d8b0 
>   duchain/clangproblem.cpp bd5a20105c1c3769791f75389afbdc93a5b9c193 
>   duchain/todoextractor.cpp 764fbd251e028df85844f98ca851a4422406d163 
>   tests/clang-parser.cpp 27b4eb535f3f47e84a495daaa60862257170f1fa 
>   tests/test_codecompletion.cpp a2ed37f55995a8d224512d59b187dba1a80ed446 
>   util/clangtypes.h 1913e444ff021b5ba3fc4a5cf555ed19e4460646 
>   util/clangutils.h af80b906eb1ca466f110c8c12637568ab1a52fc4 
>   util/clangutils.cpp 506dfdeeeccf4d665a53d0b1ebaaa608a7ec9cb5 
> 
> Diff: https://git.reviewboard.kde.org/r/125301/diff/
> 
> 
> Testing
> -------
> 
> Tests pass except for the global deleted function.
> 
> Not sure how to fix this as it seems like clang_getCursorExtent(declCursor) is wrong in that case. Or maybe I need to calaculate the range differently?
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150921/1504f497/attachment.html>