Review Request 125301: Don't show explicitly deleted/default functions in implements completion

[Sergey Kalinichev]

> On Sept. 19, 2015, 10:54 a.m., Sergey Kalinichev wrote:
> > tests/test_codecompletion.cpp, line 112
> > <https://git.reviewboard.kde.org/r/125301/diff/2/?file=404708#file404708line112>
> >
> >     Why is it even needed? The previous call should already unload the oldcpp. If it's really needed then we should do the same in all other places: test_files, test_duchain. Also, please, use just "foo.cpp" instead.
> 
> Alex Richardson wrote:
>     I added this because the test was failing for some reason. Turned out my QT_PLUGIN_PATH was wrong. I don't think this does any harm so I just left it in.

Ah, ok. Could you add this check to all tests in a separate commit then?


> On Sept. 19, 2015, 10:54 a.m., Sergey Kalinichev wrote:
> > util/clangutils.cpp, line 283
> > <https://git.reviewboard.kde.org/r/125301/diff/2/?file=404710#file404710line283>
> >
> >     It not clear for me what this comment "expose clang::FunctionDecl::isDeleted()" means. Does it mean, that http://reviews.llvm.org/D12666 doesn't fix all cases with deleted functions? If so, then please provide a test case, so that we can fix it in LibClang.
> 
> Alex Richardson wrote:
>     Well we only need isExplicitlyDefaulted() or maybe isDefaulted() (I think the latter also includes implicitly generated special functions). But for symmetry it might make sense to also add isDeleted() to libclang.

I see. Then, please change the comment a bit to reflect it, e.g. add a note that we can determine whether a function is deleted through clang_getCursorAvailability, but for symmetry with isDefaulted() it might make sense to also add isDeleted() to libclang.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125301/#review85658
-----------------------------------------------------------


On Sept. 19, 2015, 4:11 a.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125301/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2015, 4:11 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> REVIEW: 125301
> 
> 
> Diffs
> -----
> 
>   util/clangutils.cpp 506dfdeeeccf4d665a53d0b1ebaaa608a7ec9cb5 
>   tests/test_codecompletion.cpp a2ed37f55995a8d224512d59b187dba1a80ed446 
>   util/clangutils.h af80b906eb1ca466f110c8c12637568ab1a52fc4 
>   codecompletion/completionhelper.cpp df5712bb31dfa39e99a593367036d42dc41701d1 
> 
> Diff: https://git.reviewboard.kde.org/r/125301/diff/
> 
> 
> Testing
> -------
> 
> Tests pass except for the global deleted function.
> 
> Not sure how to fix this as it seems like clang_getCursorExtent(declCursor) is wrong in that case. Or maybe I need to calaculate the range differently?
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150919/cca73288/attachment.html>