Review Request 125301: Don't show explicitly deleted/default functions in implments completion

[Alex Richardson]

> On Sept. 18, 2015, 8:51 p.m., Milian Wolff wrote:
> > util/clangutils.cpp, line 303
> > <https://git.reviewboard.kde.org/r/125301/diff/1/?file=404672#file404672line303>
> >
> >     Sergey is fixing the API upstream, see http://reviews.llvm.org/D12666

This would get rid of the = delete suggestions but the = default would still be suggested in the implement completion.
I'd suggest to expose `clang::FunctionDecl::isDefaulted()` or possibly `clang::FunctionDecl::isExplicitlyDefaulted()` (not sure which) to libclang.
And while we're at it it would probably also make sense to expost `clang::FunctionDecl::isDeleted()`.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125301/#review85634
-----------------------------------------------------------


On Sept. 18, 2015, 7:20 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125301/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 7:20 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Don't show explicitly deleted/default functions in implments completion
> 
> 
> Diffs
> -----
> 
>   codecompletion/completionhelper.cpp df5712bb31dfa39e99a593367036d42dc41701d1 
>   tests/test_codecompletion.cpp a2ed37f55995a8d224512d59b187dba1a80ed446 
>   util/clangutils.h af80b906eb1ca466f110c8c12637568ab1a52fc4 
>   util/clangutils.cpp 506dfdeeeccf4d665a53d0b1ebaaa608a7ec9cb5 
> 
> Diff: https://git.reviewboard.kde.org/r/125301/diff/
> 
> 
> Testing
> -------
> 
> Tests pass except for the global deleted function.
> 
> Not sure how to fix this as it seems like clang_getCursorExtent(declCursor) is wrong in that case. Or maybe I need to calaculate the range differently?
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150918/593673cc/attachment.html>