[Differential] [Request, 2 lines] D355: Fix for Bug 352679 - QDir::cleanPath bug

claudiup (Claudiu Pop) noreply at phabricator.kde.org
Tue Sep 15 02:33:49 UTC 2015


claudiup created this revision.
claudiup added a reviewer: kfunk.
claudiup set the repository for this revision to rKDEVELOP KDevelop.
claudiup added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.

REVISION SUMMARY
  QDir::cleanPath does not seem to take into consideration symbolic links when converting file names containing pointing to a relative path. 
  
  For instance:
  QDir::cleanpath(" /bin/../lib/gcc/x86_64-redhat-linux/5.1.1/../../../../include/c++/5.1.1") returns "/include/c++/5.1.1" but this is incorrect when /lib is a symbolic link pointing to /usr/lib (Fedora 22 has this problem). Use instead QFileInfo::.canonicalFilePath which seems to do the right thing.

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D355

AFFECTED FILES
  languages/plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: claudiup, kfunk
Cc: kdevelop-devel, arrowdodger, obogdan, kfunk


More information about the KDevelop-devel mailing list