[Differential] [Commented On] D327: Optimize IndexedString::byteArray
kfunk (Kevin Funk)
noreply at phabricator.kde.org
Sun Sep 6 18:51:53 UTC 2015
kfunk added a comment.
In https://phabricator.kde.org/D327#6248, @mwolff wrote:
> This is very unsafe. When you put QByteArray anywhere and then destroy the IndexedString it may (eventually) trigger a cleanup of the item repo data, which will make the QByteArray reference destroyed data.
Right, but "you have been warned" in the documentation.
> Where is this actually required? If possible, I want to delete the bytearray getter completely, as it can lead to unicode issues.
Only used in kdevplatform/kdevelop afaics. Just removing seems possible; a few locations (around 10) in oldcpp need fixing (trivial). Will do.
To: kfunk, KDevelop
Cc: mwolff, kdevelop-devel, arrowdodger, obogdan, kfunk
More information about the KDevelop-devel