[Differential] [Commented On] D328: Introduce KDevelop::Stack (replaces QStack)

mwolff (Milian Wolff) noreply at phabricator.kde.org
Sun Sep 6 18:01:35 UTC 2015


mwolff added a subscriber: mwolff.
mwolff added a comment.

lgtm in general! thanks


INLINE COMMENTS
  language/duchain/problem.h:31 remove, seems to be unused?
  language/duchain/types/typeregister.h:120 just remove this?
  language/util/setrepository.cpp:19 remove, seems to be unused
  util/stack.h:53 please put these on multiple lines, following the KDev coding style

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D328

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, KDevelop
Cc: mwolff, kdevelop-devel, arrowdodger, obogdan, kfunk


More information about the KDevelop-devel mailing list