Review Request 125854: Port away from KDELibs4Support

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125854/#review87665
-----------------------------------------------------------


Note: kdev-upload still contains a lot of kdelibs4-foo:

% search-kdelibs4support-header.sh
./uploadprofileitem.cpp:#include <kicon.h>
./tests/permissions.cpp:#include <kcomponentdata.h>
./allprofilesmodel.cpp:#include <kdatetime.h>
./uploadjob.cpp:#include <klocale.h>
./uploadprofilemodel.cpp:#include <kcomponentdata.h>
./kdevuploadplugin.cpp:#include <klocale.h>
./profilesfiletree.cpp:#include <klocale.h>
./uploadprojectmodel.cpp:#include <kdatetime.h>
./kdevuploadplugin.h:#include <kurl.h>

This probably just works on your machine b/c you still have the kdelibs4 headers installed to some global location (i.e. /usr/include)

I suggest deinstalling those and try to compile kdev-upload again.

- Kevin Funk


On Oct. 29, 2015, 11:23 a.m., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125854/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 11:23 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-upload
> 
> 
> Description
> -------
> 
> In fact only change needed was porting to new method of resetting models in Qt.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c56ded4 
>   allprofilesmodel.cpp e4d93be 
>   uploadprojectmodel.cpp c44748f 
> 
> Diff: https://git.reviewboard.kde.org/r/125854/diff/
> 
> 
> Testing
> -------
> 
> Ran on a few projesct and tried changing settings and uploading some files. Everything seems to works as before the change.
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151029/c9aee5fa/attachment.html>