[Differential] [Request, 193 lines] D456: make qmljs kdevelop plugin compile on OSX

amccann (Andrew McCann) noreply at phabricator.kde.org
Tue Oct 27 23:43:22 UTC 2015


amccann created this revision.
amccann added reviewers: kfunk, mwolff.
Herald added a subscriber: kdevelop-devel.

REVISION SUMMARY
  It seems that when the qmljs plugin was ported over from qt-creator, the OSX specific files were left out.
   fileutils_mac.mm
   fileutils_mac.h
   autoreleasepool.h
  
  Note: I simply copied these over from HEAD of qt-creator git. 
  
  Upon inspection of the license headers of other files in that directory, this appears to match what was done before.
  
  
  This does include a modification to CMakeLists.txt to add the object-c++ file to compilation.

TEST PLAN
  Build on OSX

REPOSITORY
  rKDEVELOP KDevelop

BRANCH
  fix_qmljs_OSX

REVISION DETAIL
  https://phabricator.kde.org/D456

AFFECTED FILES
  languages/qmljs/libs/CMakeLists.txt
  languages/qmljs/libs/utils/autoreleasepool.h
  languages/qmljs/libs/utils/fileutils_mac.h
  languages/qmljs/libs/utils/fileutils_mac.mm

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: amccann, kfunk, mwolff
Cc: kdevelop-devel


More information about the KDevelop-devel mailing list