Review Request 125829: Fix Problem tooltip flickering

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125829/#review87534
-----------------------------------------------------------



plugins/problemreporter/problemhighlighter.cpp (line 123)
<https://git.reviewboard.kde.org/r/125829/#comment60094>

    join next line



plugins/problemreporter/problemhighlighter.cpp (line 137)
<https://git.reviewboard.kde.org/r/125829/#comment60095>

    can't you use the destroyed signal to achieve the same without a new signal?


- Milian Wolff


On Oct. 27, 2015, 3:59 p.m., Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125829/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 3:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Not sure why but newly introduced ActiveToolTip::closed() signal gets emitted twice when tooltip disappears.
> But anyway it doesn't case any problems.
> 
> The extra m_currentHintRange == range->toRange() check prevents from creating a new tooltip if one is already shown for this problem.
> 
> 
> Diffs
> -----
> 
>   plugins/problemreporter/problemhighlighter.h a9dbe49 
>   plugins/problemreporter/problemhighlighter.cpp c1c5c7b 
>   util/activetooltip.h 8e5399b 
>   util/activetooltip.cpp 29c4776 
> 
> Diff: https://git.reviewboard.kde.org/r/125829/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151027/60e7610f/attachment.html>