Review Request 125684: fix-definite-loop-in-CppLanguageSupport_isFunctionLike

[Jingqiang Zhang]

> On 十月 20, 2015, 12:17 p.m., Zhang HuiJie wrote:
> > Thanks for your report and patch. I have fixed it. Please go to http://commits.kde.org/kdevelop/d8df285e97447319a99e6ec88795defb42e564bb for  master and http://commits.kde.org/kdevelop/c8ff6a6cefbd9122b74fb048c37b2fc17a7e0a08 for 4.7 for more information.

Thanks.
There're still some other syntax check problems when parsing libc stdio.h and time.h.
Could you or anyone else fix that too?


- Jingqiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125684/#review87129
-----------------------------------------------------------


On 十月 20, 2015, 1:54 a.m., Jingqiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125684/
> -----------------------------------------------------------
> 
> (Updated 十月 20, 2015, 1:54 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> code like this:
> ```c
> #define a b
> #define b a
> ```
> will lead to definite loop.
> 
> and stdio.h use this:
> ```c
> /* Standard streams.  */
> extern struct _IO_FILE *stdin;		/* Standard input stream.  */
> extern struct _IO_FILE *stdout;		/* Standard output stream.  */
> extern struct _IO_FILE *stderr;		/* Standard error output stream.  */
> /* C89/C99 say they're macros.  Make them happy.  */
> #define stdin stdin
> #define stdout stdout
> #define stderr stderr
> ```
> will also lead to definite loop.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cpplanguagesupport.cpp afa2dc8 
> 
> Diff: https://git.reviewboard.kde.org/r/125684/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested
> 
> 
> Thanks,
> 
> Jingqiang Zhang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151021/d6ec46a0/attachment.html>