Review Request 125732: Removing the Build Set
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Oct 20 23:56:45 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125732/
-----------------------------------------------------------
Review request for KDevelop.
Repository: kdevplatform
Description
-------
For years my task in KDevelop has been to advertise how useful it is to have the projects loaded.
I've always had a hard time at explaining how the build set works, and many people have told me they consider it too complex. If anything, I can agree that it has a very prominent space in the UI (especially being in one of the most used ToolViews).
With this new approach we have some uses that aren't available, but I like it because it's slightly more straight to the point and it hides the complexity elsewhere.
The idea is that we will have instead just 1 item to be built/installed every time (instead of N). This is the most common use-case and that's covered.
The reason I always understood having many of them, is that sometimes you want to have a project installed before installing another one. (e.g. you are a konqueror hacker and need kparts installed every time you build konqueror). To solve this I added a project configuration page where people can add the dependencies. These will be installed every time the user builds the currently selected item.
Diffs
-----
interfaces/iprojectcontroller.h 0e232db
plugins/projectmanagerview/CMakeLists.txt cd045e1
plugins/projectmanagerview/projectbuildsetwidget.h ade1cfc
plugins/projectmanagerview/projectbuildsetwidget.cpp 7108a92
plugins/projectmanagerview/projectbuildsetwidget.ui 5de669e
plugins/projectmanagerview/projectmanagerview.h 07e24d6
plugins/projectmanagerview/projectmanagerview.cpp fd8bc02
plugins/projectmanagerview/projectmanagerview.ui 3b2a78a
plugins/projectmanagerview/projectmanagerviewplugin.h d2d7109
plugins/projectmanagerview/projectmanagerviewplugin.cpp 04af3a4
project/CMakeLists.txt 2e6fe7d
project/projectbuildsetmodel.h bce29fa
project/projectbuildsetmodel.cpp 286f668
project/projectmodel.cpp 841105d
shell/projectcontroller.h 188184c
shell/projectcontroller.cpp 766c280
tests/CMakeLists.txt bc6632b
Diff: https://git.reviewboard.kde.org/r/125732/diff/
Testing
-------
Seems to just work, I've been using it for a couple of days and I'm not annoyed. There might be quirks but my proposal is to get it in master for 5.1, it's not pressing to have it.
File Attachments
----------------
GUI
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/20/d5a791a1-45fc-4ec0-815f-68db0f7f2854__kdevelop-build.png
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151020/274eae80/attachment.html>
More information about the KDevelop-devel
mailing list