Review Request 125684: fix-definite-loop-in-CppLanguageSupport_isFunctionLike

Jingqiang Zhang zh_jq at outlook.com
Tue Oct 20 01:54:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125684/
-----------------------------------------------------------

(Updated 十月 20, 2015, 1:54 a.m.)


Review request for KDevelop.


Repository: kdevelop


Description
-------

code like this:
```c
#define a b
#define b a
```
will lead to definite loop.

and stdio.h use this:
```c
/* Standard streams.  */
extern struct _IO_FILE *stdin;		/* Standard input stream.  */
extern struct _IO_FILE *stdout;		/* Standard output stream.  */
extern struct _IO_FILE *stderr;		/* Standard error output stream.  */
/* C89/C99 say they're macros.  Make them happy.  */
#define stdin stdin
#define stdout stdout
#define stderr stderr
```
will also lead to definite loop.


Diffs
-----

  languages/cpp/cpplanguagesupport.cpp afa2dc8 

Diff: https://git.reviewboard.kde.org/r/125684/diff/


Testing
-------

Compiled and tested


Thanks,

Jingqiang Zhang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151020/7ec66d28/attachment.html>


More information about the KDevelop-devel mailing list