Review Request 125447: IVariableController: return KTE::Range of expression instead of its text.

Nicolás Alvarez nicolas.alvarez at gmail.com
Thu Oct 8 15:30:54 UTC 2015



> On Oct. 8, 2015, 7:29 a.m., Milian Wolff wrote:
> > Ship It!
> 
> Maciej Cencora wrote:
>     How do I push it? Does KDE has some github like system where I can create a repo that you would pull from?

No, there are no pull requests, (currently) Reviewboard is how you submit patches :) If you don't have developer access, just wait for an existing developer to push it for you. I don't volunteer because I haven't even compiled KDevelop recently...


- Nicolás


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125447/#review86494
-----------------------------------------------------------


On Oct. 5, 2015, 5:50 a.m., Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125447/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 5:50 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This is needed to fixup flickering in debug view navigation tooltips.
> 
> I'll create seperate review request for actual fix, but I cannot do it before this gets committed.
> 
> 
> Diffs
> -----
> 
>   debugger/interfaces/ivariablecontroller.h 9303af0 
>   debugger/variable/variablecollection.cpp 703f0ec 
>   language/duchain/duchainutils.cpp 6ea22df 
>   plugins/contextbrowser/contextbrowser.cpp 268679f 
>   plugins/patchreview/patchhighlighter.cpp 48dd127 
>   shell/mainwindow_p.cpp 134d48d 
>   shell/workingsets/workingsettoolbutton.cpp 2efadb9 
>   util/CMakeLists.txt 6a42b2c 
>   util/activetooltip.h 35b25c0 
>   util/activetooltip.cpp e45116c 
>   util/texteditorhelpers.h PRE-CREATION 
>   util/texteditorhelpers.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125447/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151008/e87fbbed/attachment.html>


More information about the KDevelop-devel mailing list