Review Request 125554: Allow for classmodel users to define which data should be collected

[Sandro Andrade]

> On Oct. 8, 2015, 10:39 a.m., Aleix Pol Gonzalez wrote:
> > language/classmodel/classmodel.h, line 60
> > <https://git.reviewboard.kde.org/r/125554/diff/1/?file=410307#file410307line60>
> >
> >     Could use a better name for the type and flags. Maybe using something positive rather than No*?

I changed the type to 'Features'. The default behavior is to have all features set, and then remove those you don't want. I've seen that idiom in Qt code before. I added an 'AllFeatures' enum flag to make that clearer, though.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125554/#review86502
-----------------------------------------------------------


On Oct. 8, 2015, 10:33 a.m., Sandro Andrade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125554/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 10:33 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> The radial bundle view uses language/classmodel to show the
> project's namespaces, classes, and methods. For that purpose,
> it requires the ability to disable the following classmodel
> features:
> 
> 1) The gathering of information about derived and base classes.
> That would make radial bundle view enter an infinite loop.
> 
> 2) The gathering of information about classes which aren't part
> of the current opened project (the focus is only intra-project
> dependencies).
> 
> 3) The gathering of information about classes' internals (member
> functions and attributes). One of the radial bundle view's aims is to
> show dependencies between classes. Showing the methods for
> big projects would make the visualization cluttered, so that we
> need an option to not go into classes internals.
> 
> 
> Diffs
> -----
> 
>   language/classmodel/classmodel.h bb3331c 
>   language/classmodel/classmodel.cpp 535da1f 
>   language/classmodel/classmodelnode.cpp c9cd8d7 
> 
> Diff: https://git.reviewboard.kde.org/r/125554/diff/
> 
> 
> Testing
> -------
> 
> It builds fine, the behavior of class browser plugins isn't affected, and radial bundle is able to collected only the required information.
> 
> 
> Thanks,
> 
> Sandro Andrade
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151008/a9d13bad/attachment.html>