Review Request 125549: using qsortfilterproxy model to sort the variables

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125549/#review86492
-----------------------------------------------------------



debugger/util/treeview.h (line 26)
<https://git.reviewboard.kde.org/r/125549/#comment59577>

    add space between include and <



debugger/variable/variablewidget.cpp (line 174)
<https://git.reviewboard.kde.org/r/125549/#comment59576>

    I agree



debugger/variable/variablewidget.cpp (line 250)
<https://git.reviewboard.kde.org/r/125549/#comment59578>

    this is OK, but even better would be to add a role for the item and then do
    
        auto item = selectionModel()->currentIndex().data(VariableCollection::ItemRole).value<TreeItem*>();


- Milian Wolff


On Oct. 7, 2015, 6:26 p.m., rishabh  gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125549/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 6:26 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Bugs: 119929
>     http://bugs.kde.org/show_bug.cgi?id=119929
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> bug 119929 .sorting varibales list alphabetically using qsortfilterproxymodel
> 
> 
> Diffs
> -----
> 
>   debugger/util/treeview.h f6a6370 
>   debugger/util/treeview.cpp ae9f0e0 
>   debugger/variable/variablewidget.cpp 79f366d 
> 
> Diff: https://git.reviewboard.kde.org/r/125549/diff/
> 
> 
> Testing
> -------
> 
> built
> 
> works fine if Q_ASSERT(qobject_cast<VariableCollection*>(model())) of variablewidget.cpp line 174 is commented out ,gives SIGABRT otherwise. Is it fine to comment it out ?
> 
> 
> Thanks,
> 
> rishabh  gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151008/4550daa8/attachment.html>