Review Request 125516: Added <month> and <day> as placeholders in license templates

Milian Wolff mail at milianw.de
Sun Oct 4 11:08:54 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125516/#review86324
-----------------------------------------------------------

Ship it!


I'll commit this for you, thanks!

- Milian Wolff


On Oct. 4, 2015, 10:55 a.m., Felix Mauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125516/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2015, 10:55 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> At work we use license headers that contain the month and day a file was created, as well. Thus I added those two placeholders to the license template parsing. It's a very minor change, so I guess, it wouldn't hurt to include it.
> 
> 
> Diffs
> -----
> 
>   plugins/filetemplates/licensepage.cpp 047d2ef 
>   plugins/filetemplates/ui/licensechooser.ui 52f60d6 
> 
> Diff: https://git.reviewboard.kde.org/r/125516/diff/
> 
> 
> Testing
> -------
> 
> Created a new file with license template holding <month> and <day> placeholders. They got replaced with the correct values as in 2015-10-04.
> 
> 
> Thanks,
> 
> Felix Mauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151004/2165cfaf/attachment.html>


More information about the KDevelop-devel mailing list