[Differential] [Commented On] D562: Don't crash if there's no context to be created

[kfunk (Kevin Funk)]

kfunk added a subscriber: kfunk.
kfunk added a comment.

Whoops, guys.

I committed a similar fix just yesterday:

  commit 9fdd73059dc191db733414ae577658e23ed51306
  Author: Kevin Funk <kfunk at kde.org>
  Date:   Sat Nov 28 16:42:14 2015 +0100
  
      Fix potential SEGV (as seen on CI)
      
      ==29050==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000020
      (pc 0x7f26e12e0cf5 sp 0x7f269f092520 bp 0x7f269f092530 T19)
          #0 0x7f26e12e0cf4 in
      KDevelop::TopDUContext::parsingEnvironmentFile() const
      /home/jenkins/builds/kdevplatform/stable-kf5-qt5/language/duchain/topducontext.cpp:550
          #1 0x7f26ad42110c in parsingEnvironmentFile
      /home/jenkins/builds/kdevelop/stable-kf5-qt5/languages/clang/clangparsejob.cpp:151
          #2 0x7f26ad424990 in
      ClangParseJob::run(QSharedPointer<ThreadWeaver::JobInterface>,
      ThreadWeaver::Thread*)
      /home/jenkins/builds/kdevelop/stable-kf5-qt5/languages/clang/clangparsejob.cpp:321
          #3 0x7f26d3af5a6a in
      ThreadWeaver::IdDecorator::run(QSharedPointer<ThreadWeaver::JobInterface>,
      ThreadWeaver::Thread*)
      /home/jenkins/builds/threadweaver/stable-kf5-qt5/src/iddecorator.cpp:69

`ClangHelpers::buildDUChain` may return a nullptr, so we definitely have to protect against this IMO...


REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D562

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, mwolff
Cc: kfunk, mwolff, kdevelop-devel, arrowdodger