Review Request 126186: more sensible workaround for code review crash on OS X

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126186/
-----------------------------------------------------------

(Updated Nov. 27, 2015, 6:29 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Software on Mac OS X and KDevelop.


Changes
-------

Submitted with commit dad5b1d5ac0e96ec218597d5d6a120b6410ece7f by René J.V. Bertin to branch 1.7.


Repository: kdevplatform


Description
-------

This patch moves the workaround from RR #120081 (commits 1f111414 and 4d2a009c) by calling `setPatch(0)` in the `PatchReviewPlugin` dtor, and using `m_patch->deleteLater()` in `setPatch()` (a change which should probably have been committed).
As a result, the `notifyChange` slot needs a nullptr check, which can then also be used to stop the update timer.


Diffs
-----

  plugins/patchreview/patchreview.cpp ad576c2 

Diff: https://git.reviewboard.kde.org/r/126186/diff/


Testing
-------

On OS X 10.9.5 with KDELibs 4.14.14 and KDevelop 4.7.2 (git/head).


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151127/106083dc/attachment.html>