Review Request 126155: Fix build without Grantlee
Alex Richardson
arichardson.kde at gmail.com
Fri Nov 27 13:20:18 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126155/
-----------------------------------------------------------
(Updated Nov. 27, 2015, 1:20 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDevelop.
Changes
-------
Submitted with commit 72add0f00cae09925a6b7693779e5b896206db00 by Alex Richardson to branch master.
Repository: kdevplatform
Description
-------
set_package_properties(... TYPE REQUIRED) is used however there are lots
of if(Grantlee5_FOUND) statements.
I can either remove these ifs or change it to recommended instead of
required
Diffs
-----
CMakeLists.txt 4edcf54ea72fbec63f8655f0fcf123de0201de5f
plugins/CMakeLists.txt 29f5d34cac9fb393463f14acacdc9a7dc9531555
template/CMakeLists.txt fc30c168122bdb6164d8c9d2cc389aff1db4b6ec
Diff: https://git.reviewboard.kde.org/r/126155/diff/
Testing
-------
I am compiling on a system without grantlee, after this patch it works
Thanks,
Alex Richardson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151127/699eb793/attachment.html>
More information about the KDevelop-devel
mailing list