Review Request 126044: Add mising dependency on kdelibs4support

Sven Brauch mail at svenbrauch.de
Wed Nov 25 09:50:49 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126044/#review88788
-----------------------------------------------------------


Sorry, I overlooked this RR. Yes, those issues were present in the tag, but reported already ... try if it's still a problem in master. In any case, kde4support is not required, instead the includes should be removed.

- Sven Brauch


On Nov. 25, 2015, 9:49 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126044/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 9:49 a.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> I'm unable to build kdev-python without this patch. Kdelibs4Support is required because of kdeversion.h and kdemacro.h headers.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1146905 
>   debugger/CMakeLists.txt 20ead1a 
>   duchain/CMakeLists.txt 2da1253 
> 
> Diff: https://git.reviewboard.kde.org/r/126044/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151125/ef0f2fa5/attachment.html>


More information about the KDevelop-devel mailing list