Review Request 126156: Allow using QtWebEngine instead of QtWebKit

[Aleix Pol Gonzalez]

> On Nov. 24, 2015, 8:49 p.m., Andrew McCann wrote:
> > Hi,
> > 
> > I made similar set of changes on my OSX branch for similar reasons. (QT5.6 wasn't compiling with webkit) (I ended up forcing webkit to compile in 5.6)
> > 
> > While a change like this DOES compile, and content does display in the QTHelp plugin. I found that I was no longer able to navigate QT Help pages. Links in the HTML itself no longer work.
> > 
> > I believe that getting QTWebEngine to work is more work than this.  The primary problem is that they don't have the same API. In this case, WebEngine doesn't have a 'c++' callback in the same way for when a link is clicked. 
> > 
> > Testing requires more than just compiling. It also requires compiling of dependencies. Kdevelop, in this case.  And it requires verifying that all the functionality is still present.
> > 
> > There also seems to be some debate as to which to support.

Yes, that's what I was thinking... I'm curious to see what they're going to do with assistant.

In any case QtWebKit is dead and we need to find a solution.

An alternative is also using QTextBrowser for QtHelp, that should work (it's the one that we used before QtWebKit).


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126156/#review88769
-----------------------------------------------------------


On Nov. 24, 2015, 6:52 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126156/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 6:52 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Allow using QtWebEngine instead of QtWebKit
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4edcf54ea72fbec63f8655f0fcf123de0201de5f 
>   documentation/CMakeLists.txt ff57e258ab5c62ce737c4013005247d585e87b61 
>   documentation/config-documentation.h.cmake PRE-CREATION 
>   documentation/standarddocumentationview.h ba454427165a0df8372fa6d51ebc714423845107 
>   documentation/standarddocumentationview.cpp a9185fd592771f9ead7d4216e08f8c93abab601a 
> 
> Diff: https://git.reviewboard.kde.org/r/126156/diff/
> 
> 
> Testing
> -------
> 
> compiles on my system which only has QtWebEngine
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151124/a998e165/attachment.html>