[Differential] [Commented On] D583: Fix DUChainUtils::getInheriters.

olivierjg (Olivier Jean de Gaalon) noreply at phabricator.kde.org
Tue Nov 24 20:51:55 UTC 2015


olivierjg added a subscriber: olivierjg.
olivierjg added a comment.

In the context of kdev-clang, "should" is a bit relative, as the plugin doesn't use the DUChain for any semantic analysis -- it's (almost) purely for visualization.
AFAICT this is just kdev-clang importing whatever clang reports with clang_getCursorSemanticParent. Since kdev-clang does have a special code-path for importing base classes as well, inheritance wouldn't be broken by simply not doing that anymore. It might break something else, but the tests should say one way or another. It's worth a shot I think, because imports make lots of lookups more expensive.


REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D583

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gsmolarczyk, KDevelop
Cc: olivierjg, mwolff, kdevelop-devel, arrowdodger


More information about the KDevelop-devel mailing list