Review Request 126156: Allow using QtWebEngine instead of QtWebKit

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126156/#review88766
-----------------------------------------------------------



CMakeLists.txt (line 48)
<https://git.reviewboard.kde.org/r/126156/#comment60860>

    this `if` should go in documentation/CMakeLists.txt


I'd like a bit more testing there. I'm quite sure QtHelp won't work with webengine... or they hacked the support in for opening QtHelp files?

- Aleix Pol Gonzalez


On Nov. 24, 2015, 6:52 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126156/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 6:52 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Allow using QtWebEngine instead of QtWebKit
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4edcf54ea72fbec63f8655f0fcf123de0201de5f 
>   documentation/CMakeLists.txt ff57e258ab5c62ce737c4013005247d585e87b61 
>   documentation/config-documentation.h.cmake PRE-CREATION 
>   documentation/standarddocumentationview.h ba454427165a0df8372fa6d51ebc714423845107 
>   documentation/standarddocumentationview.cpp a9185fd592771f9ead7d4216e08f8c93abab601a 
> 
> Diff: https://git.reviewboard.kde.org/r/126156/diff/
> 
> 
> Testing
> -------
> 
> compiles on my system which only has QtWebEngine
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151124/c9cf2552/attachment.html>