Review Request 126062: Port "Attach to process" to KF5

Milian Wolff mail at milianw.de
Sat Nov 14 15:59:01 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126062/#review88352
-----------------------------------------------------------

Ship it!


lgtm, I'll try it out right-away. Do you have commit rights?

Thanks!


debuggers/gdb/CMakeLists.txt (line 17)
<https://git.reviewboard.kde.org/r/126062/#comment60578>

    this could now also be run on mac, no? it's an optional find after all. but I'm also OK with leaving it as-is for now


- Milian Wolff


On Nov. 14, 2015, 12:31 p.m., Iain Nicol wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126062/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2015, 12:31 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This consists of tweaking the build, plus porting from KDialog to
> QDialog.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/processselection.h e6046550b6df95c5ebc973ebef758a39c1f83f16 
>   debuggers/gdb/processselection.cpp 8bee72e9d6c4ef94cd7df7084d13133b43168fd2 
>   debuggers/gdb/CMakeLists.txt 57eab84988d9f7d954545bf95a7615e002dd744a 
> 
> Diff: https://git.reviewboard.kde.org/r/126062/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Iain Nicol
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151114/068bc554/attachment.html>


More information about the KDevelop-devel mailing list