[Differential] [Commented On] D529: Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc

[amccann (Andrew McCann)]

amccann added inline comments.

INLINE COMMENTS
  app/splash.cpp:42 The QStandardPaths::locate() call above doesn't search the QRC.
  
   I was taking a strategy of 'smallest change' .. Which, in this case means that if the file is in the "legacy" path location, it would load that instead of the QRC, which.. For other files is sometimes desired (Then they can be modified, etc)
  
  That said, you raise a good point.  There's no reason to allow a custom splash.qml.
  
  This entire block could be replaced with:
  
  ```setSource(QUrl("qrc:/kdevelop/splash.qml")); ``` 
  
  I will do that.

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D529

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: amccann, kfunk, mwolff
Cc: kdevelop-devel