Review Request 125929: Fix detailed progress dialog visual glitches

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125929/#review87960
-----------------------------------------------------------

Ship it!


lgtm, and if you tested it works this is good enough for me.

should go into 5.0 once you attended the one comment I have below


shell/progresswidget/progressdialog.cpp (line 117)
<https://git.reviewboard.kde.org/r/125929/#comment60347>

    is it guaranteed to be at index 0? what if it's not, wouldn't it work more reliably to remove the item after?
    
        auto index = mBigBox->layout()->indexOf(item);
        if (index != -1) {
          auto secondItem = dynamic_cast<TransamBigBox->layout()->itemAt(index + 1);
          if (secondItem) {
            static_cast<TransactionItem *>(secondItem->widget())->hideHLine();
          }
        }


- Milian Wolff


On Nov. 3, 2015, 11:25 a.m., Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125929/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 11:25 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> As mentioned on email, currently ProgressDialog widget is hidden under any toolview (but not by the editor widget or any of IdealToolBar widgets).
> I have been unable to track down why it doesn't work with current setup design.
> According to gammaray both a toolview (e.g. "Problems", "Find/Replace in Files") and ProgressDialog are children of MainWindow widget, but still even manually raising and lowering from within GammaRay didn't fix Z-order.
> 
> The workaround "hide the tool view, and activate it again (while the detailed progress widget is shown)" actually works only for first frame, then the part of ProgressDialog overlapping with tool view widget does not update anymore.
> 
> I fixed this by converting the OverlayWidget to a popup widget (just like ActiveToolTip). Not sure whether this is the way we want to go though.
> 
> Also while there, I fixed removal of seperator line between progress items - depending on the Qt specific behavior as mentioned in removed comment doesn't seem to work out(anymore?).
> 
> 
> Diffs
> -----
> 
>   shell/progresswidget/progressdialog.cpp a9d048a 
>   shell/progresswidget/overlaywidget.cpp 6961b14 
>   shell/progresswidget/progressdialog.h d4ced74 
> 
> Diff: https://git.reviewboard.kde.org/r/125929/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151103/171b03fc/attachment-0001.html>