Review Request 123970: Use cmake to generate export headers

Aleix Pol Gonzalez aleixpol at kde.org
Sun May 31 22:09:42 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123970/#review81023
-----------------------------------------------------------

Ship it!


Looks like it could just statically link, but the patch is good anyway.

- Aleix Pol Gonzalez


On May 31, 2015, 10:06 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123970/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 10:06 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmake
> 
> 
> Description
> -------
> 
> Use cmake to generate export headers
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6b4a8eb 
>   duchain/CMakeLists.txt 6414586 
>   duchain/contextbuilder.h 475aa8e 
>   duchain/qmakeduchainexport.h 99334e1 
>   duchain/qmakeeditorintegrator.h a558aaa 
>   parser/CMakeLists.txt d844a1e 
>   parser/ast.h 4538388 
>   parser/parserexport.h 8f81f0b 
>   parser/qmakeastdefaultvisitor.h 3f140e6 
>   parser/qmakeastvisitor.h 1261466 
>   parser/qmakedriver.h da5fb87 
>   parser/qmakelexer.h 3f0e46d 
> 
> Diff: https://git.reviewboard.kde.org/r/123970/diff/
> 
> 
> Testing
> -------
> 
> yes,
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150531/16d73225/attachment.html>


More information about the KDevelop-devel mailing list