Review Request 123962: Add support for the goto statement

Olivier Jean de Gaalon olivier.jg at gmail.com
Sun May 31 16:13:50 UTC 2015



> On May 31, 2015, 9:06 a.m., Olivier Jean de Gaalon wrote:
> > duchain/cursorkindtraits.h, line 280
> > <https://git.reviewboard.kde.org/r/123962/diff/1/?file=378425#file378425line280>
> >
> >     Add "Label" here
> 
> Sergey Kalinichev wrote:
>     Not sure how I'm suppose to do that. CXCursor_LabelStmt has CXType_Invalid type. Should I create the "Label" identifier for all invalid types then?

Sorry, wrong overload, you're right. Use "static const IndexedTypeIdentifier" like the other overload does though.


- Olivier Jean de


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123962/#review80995
-----------------------------------------------------------


On May 31, 2015, 8:26 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123962/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 8:26 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Add support for the goto statement
> 
> 
> Diffs
> -----
> 
>   duchain/builder.cpp b64d4e0 
>   duchain/cursorkindtraits.h a623861 
>   tests/files/goto.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123962/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150531/40623cc0/attachment.html>


More information about the KDevelop-devel mailing list