Review Request 123960: Set empty ranges for uses of some operators

[Sergey Kalinichev]

> On May 31, 2015, 11:51 a.m., Olivier Jean de Gaalon wrote:
> > I have two issues with this:
> > 1. This seems like an overkill way of saying that CXCursor_ArraySubscriptExpr and CXCursor_ConversionFunction should collapse their range. A function taking the cursor kind and useRange and returning a RangeInRevision could work as well, no?
> > 2. IMO these two types should include the opening '(' or '[' in their range, as in oldcpp. Not really ideal, but better than empty I think.

1. I didn't know about these: CXCursor_ArraySubscriptExpr and CXCursor_ConversionFunction. I'll try to do it.
2. Ok, let's do it that way.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123960/#review80994
-----------------------------------------------------------


On May 31, 2015, 11:22 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123960/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 11:22 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Once again, uses of those operators invisible, no need to highlight them
> 
> 
> Diffs
> -----
> 
>   duchain/builder.cpp b64d4e0 
>   tests/files/operators.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123960/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150531/38ffc378/attachment-0001.html>