Review Request 123933: Set empty ranges for declarations inside macro expansion

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123933/#review80944
-----------------------------------------------------------



duchain/builder.cpp (line 324)
<https://git.reviewboard.kde.org/r/123933/#comment55455>

    add a comment:
    
    // check if cursor is inside a macro expansion
    
    also: what about nested macro expansions, are they OK to not get this treatment?



tests/files/macros.cpp (line 1)
<https://git.reviewboard.kde.org/r/123933/#comment55456>

    according to this test, it worked fine even before, no? I seem to have trouble understanding how the code below with the Cursor is related to uses inside a macro expansion. could you please elaborate?



tests/test_duchain.cpp (line 893)
<https://git.reviewboard.kde.org/r/123933/#comment55457>

    hm this is not optimal, is it? shouldn't the range be that of the "x" macro argument? i.e. {1, 12, 1, 13}?


- Milian Wolff


On May 29, 2015, 9:34 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123933/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 9:34 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Those declarations are invisible, so there is no need to highlight and enable navigation widget for them.
> 
> 
> Diffs
> -----
> 
>   duchain/builder.cpp 260b4e2 
>   tests/files/macros.cpp 539afff 
>   tests/test_duchain.cpp 403e7c1 
> 
> Diff: https://git.reviewboard.kde.org/r/123933/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150529/b6407906/attachment.html>