Review Request 123878: Introduction of a Concentration mode

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123878/#review80890
-----------------------------------------------------------


looks cool, I'd like to try it out. but I really fear the change in keys regarding alt <-> ctrl for showing the navigation popup is too invasive... any ideas what else we could do here?


sublime/mainwindow_p.cpp (line 112)
<https://git.reviewboard.kde.org/r/123878/#comment55417>

    these key changes can be pushed directly in a separate commit, imo



sublime/mainwindow_p.cpp (line 208)
<https://git.reviewboard.kde.org/r/123878/#comment55418>

    using findChild(ren) is really ugly, imo, could you add proper API here instead? i.e. new member variables that get be set further below?



sublime/mainwindow_p.cpp (line 237)
<https://git.reviewboard.kde.org/r/123878/#comment55419>

    QStringLiteral?



sublime/mainwindow_p.cpp (line 260)
<https://git.reviewboard.kde.org/r/123878/#comment55420>

    remove or comment out



sublime/mainwindow_p.cpp (line 265)
<https://git.reviewboard.kde.org/r/123878/#comment55421>

    the name is odd, as it also checks the altmodifier. noOrAltModifier ?



sublime/mainwindow_p.cpp (line 273)
<https://git.reviewboard.kde.org/r/123878/#comment55422>

    what do you mean by "not in use" and would that be done inside the eventFilter?


- Milian Wolff


On May 22, 2015, 1:06 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123878/
> -----------------------------------------------------------
> 
> (Updated May 22, 2015, 1:06 a.m.)
> 
> 
> Review request for KDevelop and KDE Usability.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> One of the perceived problems in KDevelop that affect me the most is that we're visually heavy. And we are. This patch doesn't address this, but I believe it will start to give us some hints on where we want to go.
> 
> This patch, basically adds a new togglable state to the main window, which allows our user to reduce some of the noise in the UI, allowing him to concentrate on what he came to do. This has a big advantage: we get to assume that the user is familiar with the shortcuts.
> What it does:
> 
> * It hides all the toolview handles (not the toolviews).
> * It hides the menu bar. Since I realized I was using Alt+* to access some menus, it's showing the menu when Alt is pressed.
> * It adds a toolbar that lets the user get out of the concentration mode, and also receives the menu widget (with the working sets and area button).
> * Also since I realized I was using some other shortcuts, I took the liberty to adapt them, I think they're far easier to remember than the previous ones.
> * Replaces the container tab bar to work without it (it has a label instead, long story, I know).
> 
> Now it works reasonably well, you can see the screenshot if you want to get an idea without trying the patch. I'm still undecided about whether we want to hide them.
> 
> 
> Diffs
> -----
> 
>   plugins/contextbrowser/browsemanager.cpp 70a3125 
>   sublime/mainwindow.cpp a1acdf3 
>   sublime/mainwindow_p.h ed8f493 
>   sublime/mainwindow_p.cpp 3091661 
> 
> Diff: https://git.reviewboard.kde.org/r/123878/diff/
> 
> 
> Testing
> -------
> 
> I've been using it for work during the last few days. It doesn't crash (more) and well, I don't miss most of the things, so it's probably safe to get this in as is.
> 
> 
> File Attachments
> ----------------
> 
> Small Window
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/22/f4ee28f6-1e0c-41bc-8d7a-b216d23ca5f4__kdevelop-concentration.png
> Concentration Mode
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/22/62c102b1-dbc7-4bd3-9e96-7b866709ca3b__kdevelop-concentration-1.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150527/8e449a87/attachment.html>