Review Request 123914: Try to handle the ElaboratedType

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123914/#review80885
-----------------------------------------------------------



tests/test_duchain.cpp (line 947)
<https://git.reviewboard.kde.org/r/123914/#comment55413>

    That loop is cumbersome, also given that you branch on `i` inside the loop again.
    
    Please ditch the loop, and test one by one; or even better, turn into a data-driven test case. Generally, unit tests should be very simple to read and contain as less branching as possible.


Rest looks fine, thanks

- Kevin Funk


On May 27, 2015, 9:17 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123914/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 9:17 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This type currently is not exposed through the libclang interface.
> So let's use clang_getCanonicalType on it to get at least some data.
>     
> Of course the clang_getCanonicalType will strip away all typedef information, but it's still better than nothing at all.
> 
> 
> Diffs
> -----
> 
>   tests/test_duchain.cpp 07e8e38 
>   tests/test_duchain.h 5f65284 
>   duchain/builder.cpp 04b067a 
> 
> Diff: https://git.reviewboard.kde.org/r/123914/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150527/5c4c9a42/attachment.html>