Review Request 123856: kf5 : port away from KCmdLineArgs

Aleix Pol Gonzalez aleixpol at kde.org
Tue May 19 22:17:32 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123856/#review80643
-----------------------------------------------------------



parser/main.cpp (line 39)
<https://git.reviewboard.kde.org/r/123856/#comment55295>

    maybe you want to do the setupCommandLine/processCommandLine. That's what the comment is telling you.



parser/main.cpp (line 50)
<https://git.reviewboard.kde.org/r/123856/#comment55294>

    You forgot to port this.


- Aleix Pol Gonzalez


On May 19, 2015, 10:10 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123856/
> -----------------------------------------------------------
> 
> (Updated May 19, 2015, 10:10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmake
> 
> 
> Description
> -------
> 
> I've just used kde-dev-scripts/kf5/convert-kcmdlineargs.pl
> 
> 
> Diffs
> -----
> 
>   parser/main.cpp 4f368cc 
> 
> Diff: https://git.reviewboard.kde.org/r/123856/diff/
> 
> 
> Testing
> -------
> 
> Yes, open a .pro and building project
> non regression seen
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150519/d1620237/attachment.html>


More information about the KDevelop-devel mailing list