Review Request 123809: Use list of hard coded colors instead of generating it

[Sergey Kalinichev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123809/
-----------------------------------------------------------

(Updated May 19, 2015, 6:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Changes
-------

Submitted with commit cd281df54e177d44a78f067fefe91118afd37749 by Sergey Kalinichev to branch master.


Repository: kdevplatform


Description
-------

This fixes 2 issues:

*Currently rainbow highlighting only works for the first 10 declarations in Function and Other contexts. All other declarations get highlighted with the default color.
*The current interpolation algorithm is very poor, it can generate only about 10 different colors, all other look alike.
    
So this patch adds ~35 distinguishable colors, which should be more than enough for most cases.


Diffs
-----

  language/highlighting/codehighlighting.cpp 59a7ffc 
  language/highlighting/colorcache.h d04dfc5 
  language/highlighting/colorcache.cpp e2729f2 

Diff: https://git.reviewboard.kde.org/r/123809/diff/


Testing
-------


File Attachments
----------------

primary_colors.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/17/4b5c74df-4f42-4a0d-8384-e82bd2b1214f__primary_colors.png
all_colors.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/17/6f700794-b2d1-4a48-97d4-3e354f3e7701__all_colors.png


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150519/685de6e0/attachment.html>