Review Request 123741: Port away from KDebug

[Kevin Funk]

> On May 13, 2015, 8:47 p.m., Laurent Navet wrote:
> > qmakebuilder/qmakebuilderdebug.cpp, line 21
> > <https://git.reviewboard.kde.org/r/123741/diff/1/?file=368419#file368419line21>
> >
> >     Is this distinction between kdevelop.plugins.qmake and kdevelop.plugins.qmakebuilder is really needed ?
> >     maybe using kdevelop.plugins.qmake everywhere is sufficient ?

Yeah, let's leave the distinction. It's the same for the other project builders in kdevelop.git.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123741/#review80318
-----------------------------------------------------------


On May 12, 2015, 8:47 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123741/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 8:47 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmake
> 
> 
> Description
> -------
> 
> KDebug is deprecated, use QDebug, also remove calls to KBacktrace
> 
> 
> Diffs
> -----
> 
>   parser/buildastvisitor.cpp 202f4ba 
>   parser/main.cpp 720ed33 
>   parser/qmake.g ce87992 
>   parser/qmakedebugvisitor.cpp b98281d 
>   parser/qmakedriver.cpp 3542715 
>   parser/tests/CMakeLists.txt dc8e692 
>   qmakebuilddirchooser.cpp d1dbc25 
>   qmakebuilddirchooserdialog.cpp eff28a8 
>   qmakebuilder/CMakeLists.txt 7e1d7e2 
>   qmakebuilder/qmakebuilder.cpp 83fdebe 
>   qmakebuilder/qmakebuilderdebug.h PRE-CREATION 
>   qmakebuilder/qmakebuilderdebug.cpp PRE-CREATION 
>   qmakebuilder/qmakebuilderpreferences.cpp d4c3de9 
>   qmakeconfig.cpp e20bec8 
>   qmakefile.cpp 2107524 
>   qmakefilevisitor.cpp f04bf1f 
>   qmakejob.cpp 469b250 
>   qmakemanager.cpp f93656c 
>   qmakeprojectfile.cpp a2831e4 
>   tests/CMakeLists.txt 48f1b99 
>   tests/test_qmakeproject.cpp 3b7cdd7 
>   variablereferenceparser.cpp 941416f 
> 
> Diff: https://git.reviewboard.kde.org/r/123741/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150514/12298c19/attachment.html>