Review Request 123702: rpp: test for mispaired brackets

Zhang HuiJie yitianbuji at gmail.com
Mon May 11 10:01:48 UTC 2015



> On 五月 11, 2015, 2:43 p.m., Kevin Funk wrote:
> > Ship It!
> 
> Kevin Funk wrote:
>     You can't commit yourself I presume?

I have no commit rights, and thank you very much:).


- Zhang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123702/#review80194
-----------------------------------------------------------


On 五月 9, 2015, 9:07 p.m., Zhang HuiJie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123702/
> -----------------------------------------------------------
> 
> (Updated 五月 9, 2015, 9:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> one test added, for the current macro expander doesn't check  brackets fully
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/tests/test_parser.cpp 775ce88 
> 
> Diff: https://git.reviewboard.kde.org/r/123702/diff/
> 
> 
> Testing
> -------
> 
> the expander handles this one well:
> 
> #if (1 //error expected, and we got it
> #endif 
> 
> but  nothing reported with this one:
> #if 1)  
> #endif
> 
> 
> Thanks,
> 
> Zhang HuiJie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150511/89f72b39/attachment.html>


More information about the KDevelop-devel mailing list