Review Request 123655: Clarify/fix error message

[Aleix Pol Gonzalez]

> On May 6, 2015, 3:12 p.m., Aleix Pol Gonzalez wrote:
> > To be honest, I see why you think it should be improved, but your alternative is not all that better...
> > 
> > What about just "Could not generate file '%1'"?
> 
> Alexander Potashev wrote:
>     "Could not generate ..." is no bueno because the file already exists before extractFileMacros() is called - it is firstly copied and then filled with the specific values of variables. "Generate" usually stands for the whole process of creating a file from scratch.
> 
> Milian Wolff wrote:
>     yeah I also think your new message is better than what we had before. generally, the function is probably a misnomer as well and should be renamed accordingly (if possible, i.e. if its internal and would not break the API).
>     
>     Also, what about:
>     
>     Failed to replace macros in file %1.

Then remove the file? the process failed and should be rolled back, instead of leaving half-done stuff...


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123655/#review79967
-----------------------------------------------------------


On May 6, 2015, 8:18 a.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123655/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 8:18 a.m.)
> 
> 
> Review request for KDevelop and Simon Wächter.
> 
> 
> Repository: kapptemplate
> 
> 
> Description
> -------
> 
> Clarify/fix error message
> 
> I'm unsure about this change because the helper function is called GeneratePage::extractFileMacros for some reason, I don't understand why "extract". Please comment.
> 
> 
> Diffs
> -----
> 
>   src/application/generatepage.cpp 66a39644c6ef71f38f615ebe6d67b2a94e86e272 
> 
> Diff: https://git.reviewboard.kde.org/r/123655/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150506/f6ceb800/attachment.html>