Review Request 123656: Added clang highlighting

Milian Wolff mail at milianw.de
Wed May 6 19:46:18 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123656/#review79982
-----------------------------------------------------------



clanghighlighting.cpp (line 40)
<https://git.reviewboard.kde.org/r/123656/#comment54865>

    the two colors should be moved to codehighlighting.cpp / .h in kdevplatform and made accessible via new Types. this allows them to be cached there
    
    then, it would be sufficient to overload typeForDeclaration below, instead of highlightDeclaration/highlightUse and return one of the new types depending on whether a macro is function like or not.
    
    furthermore, the default of a non-functionlike macro should be handled in kdevplatform based on the new Declaration::Macro kind. Only the isFunctionLike is special for clang and be used here


- Milian Wolff


On May 6, 2015, 7:40 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123656/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 7:40 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Now we highlight macros too
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 42a0aeb 
>   clanghighlighting.h PRE-CREATION 
>   clanghighlighting.cpp PRE-CREATION 
>   clangsupport.cpp 510e244 
> 
> Diff: https://git.reviewboard.kde.org/r/123656/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150506/837946d4/attachment-0001.html>


More information about the KDevelop-devel mailing list