Review Request 123655: Clarify/fix error message
Aleix Pol Gonzalez
aleixpol at kde.org
Wed May 6 13:12:46 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123655/#review79967
-----------------------------------------------------------
To be honest, I see why you think it should be improved, but your alternative is not all that better...
What about just "Could not generate file '%1'"?
- Aleix Pol Gonzalez
On May 6, 2015, 8:18 a.m., Alexander Potashev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123655/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 8:18 a.m.)
>
>
> Review request for KDevelop and Simon Wächter.
>
>
> Repository: kapptemplate
>
>
> Description
> -------
>
> Clarify/fix error message
>
> I'm unsure about this change because the helper function is called GeneratePage::extractFileMacros for some reason, I don't understand why "extract". Please comment.
>
>
> Diffs
> -----
>
> src/application/generatepage.cpp 66a39644c6ef71f38f615ebe6d67b2a94e86e272
>
> Diff: https://git.reviewboard.kde.org/r/123655/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Potashev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150506/aa8215ac/attachment.html>
More information about the KDevelop-devel
mailing list