Review Request 123279: Add color tab feature

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123279/#review79916
-----------------------------------------------------------

Ship it!


Hey! Thanks for the update. This looks pretty good now, I think we should give it a try. But please make this new feature off-by-default.

I've also marked a bunch of style issues in this review. Please take that into account for future patches if possible. Since our old codebase is not really good at being consistent, I could also take care of fixing these issues myself if you prefer. Do you have a KDE account btw? If not, then we'll need to push it on your behalf anyways and could do these minor cleanups.


plugins/projectmanagerview/projecttreeview.cpp (line 455)
<https://git.reviewboard.kde.org/r/123279/#comment54759>

    this new feature should be off by default



plugins/projectmanagerview/projecttreeview.cpp (line 463)
<https://git.reviewboard.kde.org/r/123279/#comment54758>

    wrong indentation



shell/mainwindow.h 
<https://git.reviewboard.kde.org/r/123279/#comment54760>

    unrelated change. tip: try "git checkout -p" to interactively undo such hunks



shell/mainwindow.h (line 93)
<https://git.reviewboard.kde.org/r/123279/#comment54761>

    again, unrelated



shell/mainwindow.cpp (line 309)
<https://git.reviewboard.kde.org/r/123279/#comment54763>

    why queued connections here and below?



shell/mainwindow.cpp (line 311)
<https://git.reviewboard.kde.org/r/123279/#comment54762>

    remove the space after the `connect(`



shell/mainwindow.cpp (line 359)
<https://git.reviewboard.kde.org/r/123279/#comment54764>

    here and below: add space after if and before the {
    
    also make the setting off by default please.



shell/mainwindow.cpp (line 361)
<https://git.reviewboard.kde.org/r/123279/#comment54766>

    join with next line



shell/mainwindow.cpp (line 366)
<https://git.reviewboard.kde.org/r/123279/#comment54765>

    `} else {`



shell/mainwindow.cpp (line 367)
<https://git.reviewboard.kde.org/r/123279/#comment54769>

    move * next to typename



shell/mainwindow.cpp (line 375)
<https://git.reviewboard.kde.org/r/123279/#comment54770>

    move * next to typename, i.e. remove space after IDocument



shell/mainwindow.cpp (line 381)
<https://git.reviewboard.kde.org/r/123279/#comment54767>

    off by default. can we have this in a central function maybe to share the code?



shell/mainwindow.cpp (line 391)
<https://git.reviewboard.kde.org/r/123279/#comment54768>

    join with next line, also move * next to typename



shell/plugincontroller.cpp 
<https://git.reviewboard.kde.org/r/123279/#comment54771>

    unrelated change



shell/projectcontroller.cpp (line 1192)
<https://git.reviewboard.kde.org/r/123279/#comment54772>

    join with next line



shell/projectcontroller.cpp (line 1196)
<https://git.reviewboard.kde.org/r/123279/#comment54773>

    join with next two lines



shell/settings/uiconfig.kcfg (line 16)
<https://git.reviewboard.kde.org/r/123279/#comment54775>

    off by default please



shell/uicontroller.cpp 
<https://git.reviewboard.kde.org/r/123279/#comment54774>

    unrelated changes



sublime/container.cpp (line 482)
<https://git.reviewboard.kde.org/r/123279/#comment54777>

    space after for



sublime/container.cpp (line 490)
<https://git.reviewboard.kde.org/r/123279/#comment54778>

    space after for



sublime/container.cpp (line 494)
<https://git.reviewboard.kde.org/r/123279/#comment54776>

    style:
    
        if (...) {
            ...
        }


- Milian Wolff


On April 29, 2015, 8:17 p.m., Sebastien Speierer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123279/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 8:17 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This patch adds a checkbox in the KDevelop setting that allows KDevelop to color the tabs (of the open files) depending of their project.
> This feature was asked by several users on the KDE bugtracking system.
> 
> 
> Diffs
> -----
> 
>   interfaces/iprojectcontroller.h 86c2dfd 
>   plugins/projectmanagerview/projectmodelitemdelegate.cpp 69fd6c4 
>   plugins/projectmanagerview/projecttreeview.h 6512157 
>   plugins/projectmanagerview/projecttreeview.cpp dbd25ff 
>   shell/mainwindow.h ae22648 
>   shell/mainwindow.cpp 8757942 
>   shell/plugincontroller.cpp 362bfb0 
>   shell/projectcontroller.h 062e200 
>   shell/projectcontroller.cpp 50bdce4 
>   shell/settings/uiconfig.kcfg b168294 
>   shell/settings/uiconfig.ui a0d76de 
>   shell/uicontroller.cpp 2108ff2 
>   sublime/container.h 9049f55 
>   sublime/container.cpp 4444077 
> 
> Diff: https://git.reviewboard.kde.org/r/123279/diff/
> 
> 
> Testing
> -------
> 
> I tested the feature (open file before/after enable the coloring, tried to open files from several different projects,...), the implementation seems robust.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot01
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/22/c544c7ee-765e-4851-be5c-86d5b2241dab__kdevelop5_env_1.png
> Screenshot #2 project_manager
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/79fa321d-3952-43d7-83e8-4af07116c82f__kdevelop5_env_2.png
> Dark scheme color handled
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/8125d1e3-fb1d-4268-a100-c47523b9aa8e__kdevelop5_env_3.png
> 
> 
> Thanks,
> 
> Sebastien Speierer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150505/d35bde27/attachment-0001.html>