Review Request 123644: Change kind for type aliases to Declaration::Type

Milian Wolff mail at milianw.de
Tue May 5 19:30:44 UTC 2015



> On May 5, 2015, 6:57 p.m., Milian Wolff wrote:
> > further up we also dec->setIsTypeAlias, that is not sufficient? anyhow, if that's what oldcpp did/does, then I'm all for it.
> 
> Sergey Kalinichev wrote:
>     Seems like it's not enough, because e.g. codehighlighting checks that the kind is set to Declaration::Type

oh well, our convoluted old codebase :) I gave my +1 so please push it upstream.

Thanks Sergey!


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123644/#review79905
-----------------------------------------------------------


On May 5, 2015, 6:26 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123644/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 6:26 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This enables highlighting of typedef's
> 
> 
> Diffs
> -----
> 
>   duchain/tuduchain.h c289758 
>   tests/files/types.cpp a755c05 
> 
> Diff: https://git.reviewboard.kde.org/r/123644/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150505/8d24c330/attachment.html>


More information about the KDevelop-devel mailing list