Review Request 123134: Don't hardcode paths

Milian Wolff mail at milianw.de
Tue May 5 19:22:27 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123134/#review79911
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On March 25, 2015, 11:38 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123134/
> -----------------------------------------------------------
> 
> (Updated March 25, 2015, 11:38 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> 3 commits:
> 
> ----
> 
> 
> Don't hardcode /usr/bin/pep8ify
> 
> I am pretty sure that it will be /usr/local/bin/pep8ify on any BSD
> system
> 
> ----
> 
> Don't hardcode /usr/bin/pep8-python2
> 
> I am pretty sure that it will be /usr/local/bin/pep8-python2 on any BSD
> system. Additionally we should probably use pep8-python3 now since the
> plugin is based on python3
> 
> ----
> 
> don't bother executing an invalid executable
> 
> This should fix the horde of zombie processes appearing
> 
> Should be backported to KDE4 branch, but I have no setup to test that
> 
> CCBUG: 345527
> 
> 
> Diffs
> -----
> 
>   pep8kcm/kcm_pep8.h 24d885ce5a303c388528411bae27eeecb667a40e 
>   pep8kcm/kcm_pep8.cpp 16ba0c2eccb4de82607ebaa32f4104fc3e9670d3 
>   pythonlanguagesupport.cpp 9ac3e5005dcce9199c129a782e34eb824ec756fa 
>   pythonparsejob.cpp 3571ed2793ebf030ebf0d529e8960cdd127e59d8 
> 
> Diff: https://git.reviewboard.kde.org/r/123134/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150505/6357ed0b/attachment.html>


More information about the KDevelop-devel mailing list