Review Request 123519: lazy check if function like

Milian Wolff mail at milianw.de
Tue May 5 19:19:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123519/#review79909
-----------------------------------------------------------



languages/cpp/cpplanguagesupport.cpp (line 828)
<https://git.reviewboard.kde.org/r/123519/#comment54755>

    where does the second->function_like come from? shouldn't that be fixed instead? or, alternatively, can it be removed now?


- Milian Wolff


On April 27, 2015, 9:01 a.m., Zhang HuiJie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123519/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 9:01 a.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> new implementation of checking if a macro function like, it just check while when we need.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cpplanguagesupport.h e1659ae 
>   languages/cpp/cpplanguagesupport.cpp a0f47b1 
> 
> Diff: https://git.reviewboard.kde.org/r/123519/diff/
> 
> 
> Testing
> -------
> 
> I had discard the previous implementation(https://git.reviewboard.kde.org/r/122975/) for huge cost, this one work well and no obvious cost :).
> 
> 
> Thanks,
> 
> Zhang HuiJie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150505/2ff0b90f/attachment.html>


More information about the KDevelop-devel mailing list