Review Request 123644: Change kind for type aliases to Declaration::Type

[Sergey Kalinichev]

> On May 5, 2015, 9:34 p.m., Alex Richardson wrote:
> > duchain/tuduchain.h, line 429
> > <https://git.reviewboard.kde.org/r/123644/diff/1/?file=366493#file366493line429>
> >
> >     Shouldn't it be Declaration::Alias?
> >     
> >     Not sure what `isAliasType()` does. Does it also include `namespace Foo = Bar` expressions?
> >     If so add a check for that and then set it to Declaration::NamespaceAlias.

I don't know. The comment for the Declaration::Type says: "A type is declared, like a class-declaration or function-declaration, or a typedef". So I guess it should be Declaration::Type after all. Also setting the type to Declaration::Alias doesn't fix the code highlighting issue and triggers assert at contextbrowser.cpp\:473

>Does it also include namespace Foo = Bar expressions

No. It includes only two cases that checked in the unit test.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123644/#review79904
-----------------------------------------------------------


On May 5, 2015, 9:26 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123644/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 9:26 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This enables highlighting of typedef's
> 
> 
> Diffs
> -----
> 
>   duchain/tuduchain.h c289758 
>   tests/files/types.cpp a755c05 
> 
> Diff: https://git.reviewboard.kde.org/r/123644/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150505/2d35fe16/attachment-0001.html>