Review Request 123563: Allow setting custom code completion icons

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123563/
-----------------------------------------------------------

(Updated May 4, 2015, 3:59 p.m.)


Review request for KDevelop.


Changes
-------

Added outline screenshots for https://paste.kde.org/pmhiwt0zp


Repository: kdevplatform


Description
-------

This will make it easier for people that regularly use other IDEs. My
motivation here is that I often used Eclipse for Java development (and
also sometimes for C) and find the mixture of custom icons and ones from
Visual Studio that is used in KDevelop quite confusing in comparison.

This feature is customizable in the Language Support settings. If the
default of "KDevelop Classic" is used there it should have no visible
change to the used icons other than the fact that the namespace icon is
now used instead of the default fallback of field.png

The Eclipse code completion theme is available from
http://quickgit.kde.org/?p=scratch%2Farichardson%2Feclipse-codecompletion-icons.git
or as prebuilt RPM from
http://download.opensuse.org/repositories/home:/a_richardson/openSUSE_Tumbleweed/noarch/

The plugin version has been increased since a new virtual function was
added to interfaces/icompletionsettings.h


Diffs
-----

  interfaces/icompletionsettings.h 4b95c5184cf3b950907f291986a1efa2ad48d032 
  CMakeLists.txt 08ae3dacd7732d07283e742ee00af3be4bb9fe2b 
  language/CMakeLists.txt 171428eaca3786a54b63691fd12eef9b6b29cf7c 
  language/codecompletion/normaldeclarationcompletionitem.cpp 4f98e4843ff790319ef6e1aecb182d8d716d5431 
  language/duchain/duchainutils.h 7d4760af955f37c0ad87f4635ddaa8ce31eb445b 
  language/duchain/duchainutils.cpp 8a26194dcadeb98c94785fecd1b69c91ca0b4502 
  language/duchain/types/typesystem.h a054882bcf9039f74a5062d85ccf8f5c2e49b301 
  plugins/outlineview/outlinenode.cpp fedcbd87cc8dc6e9e18bad1336e912a643af6722 
  shell/completionsettings.h 05f166b4323c773c38ceb6703f36aabe35900636 
  shell/completionsettings.cpp 89cf68b46e312e0a54cd67cf7235ff5930833f82 
  shell/settings/ccconfig.kcfg 624d8da97580266f52220258e7aa42e0067e76a3 
  shell/settings/ccpreferences.h a736c3674784c173837e80758520e6618700d2a5 
  shell/settings/ccpreferences.cpp 9346e2397ea4225f9bde02ab4c30889ab0732d24 
  shell/settings/ccpreferences.ui 48bd90f44f670b5ea879bc6b187ead8c9bcbba30 
  util/CMakeLists.txt 95dd68ee31e0b7845374af7f5b27496627998345 
  util/iconutils.h PRE-CREATION 
  util/iconutils.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123563/diff/


Testing
-------

Icons are loaded, switching between themes also works

Examples below are from the outline view plugin (https://git.reviewboard.kde.org/r/123562/)


File Attachments (updated)
----------------

eclipse_icons2.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/d365bd2b-20a5-4b8f-9743-84efbf552577__eclipse_icons2.png
eclipse_icons3.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/ef3ecddd-2a0e-40d1-acd4-db105d2e3748__eclipse_icons3.png
eclipse_icons4.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/b22651f8-f260-467a-85b6-36592f7176fd__eclipse_icons4.png
outline_breeze.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/04/e87bfc98-7bbb-4bc4-816a-de0a9cb97b5e__outline_breeze.png
outline_eclipse.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/04/a9d15e25-ade2-4513-8dee-fa1bf90fde2c__outline_eclipse.png
outline_kdevelop.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/04/04301559-8e04-46d9-ad39-124e844ab7bf__outline_kdevelop.png
outline_oxygen.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/04/91fefc21-2b27-4e39-8d0c-fc3bb2320fff__outline_oxygen.png
settings.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/04/b3c15058-f43e-4a9a-987f-8a6c8753e6b9__settings.png


Thanks,

Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150504/0cf561f2/attachment.html>