Review Request 123135: Port away SVN plugin from KDialog

Aleix Pol Gonzalez aleixpol at kde.org
Sat Mar 28 00:55:32 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123135/#review78135
-----------------------------------------------------------

Ship it!



plugins/subversion/svnssldialog.cpp (line 77)
<https://git.reviewboard.kde.org/r/123135/#comment53532>

    In else:
    if () temporary = true else temporary = false;


- Aleix Pol Gonzalez


On March 27, 2015, 10:52 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123135/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 10:52 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Port away SVN plugin from KDialog
> 
> 
> Diffs
> -----
> 
>   plugins/subversion/tests/svnrecursiveadd.cpp 9672ca3ec09249468a662c2402b20aa1721a5e38 
>   plugins/subversion/svnssldialog.cpp 23b4bc4cedc7ab9571eedd3f0ad790e52689b4d7 
>   plugins/subversion/svnssldialog.h 5f9565e0a99777c17d4248593e0a76cc4fb6f0dd 
>   plugins/subversion/svncheckoutjob.cpp 0cdd5025fed17dbfc6644e592c073a032c0804d0 
>   plugins/subversion/CMakeLists.txt 4da8b2d6d6093c2a8afa2c1b0b2d2e0f10f7167b 
>   plugins/subversion/kdevsvnplugin.cpp 7e6e6ec12b8a003e045617643d779f1d1fac42ad 
> 
> Diff: https://git.reviewboard.kde.org/r/123135/diff/
> 
> 
> Testing
> -------
> 
> Compiles, but couldn't test because for some reason KDevelop hangs when connecting SVN server.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150328/53f5f68e/attachment.html>


More information about the KDevelop-devel mailing list