Review Request 123158: Remove KDELibs4Support

Sat Mar 28 00:46:43 UTC 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123158/#review78134
-----------------------------------------------------------

Ship it!

AFAIU, it's just removing headers and whitespaces, there's no code changes. I'm fine with this. I'd say just commit this and just remove the find_package in a separate commit after the KDialog uses have been removed.

Good work!

- Aleix Pol Gonzalez

On March 28, 2015, 12:11 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123158/
> -----------------------------------------------------------
> 
> (Updated March 28, 2015, 12:11 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Remove KDELibs4Support and cleanup headers
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4f9a7bb243120ad132b2ad1015475f885d24c9be 
>   debugger/variable/variablewidget.h 235ba08f5dc08ecfbf5e3b0e47052b8b692dcec3 
>   debugger/variable/variablewidget.cpp d48d2111eff839cc40725ce55673d53bde4d241d 
>   interfaces/ipartcontroller.cpp bf2ccf590c95caf2e3f5674ba2c7227137dc6ac6 
>   interfaces/iplugin.cpp 270a72aedf60f68d502b35fabb5d3cefd8ef6238 
>   language/assistant/renameassistant.cpp fef0caa9f100fba167bf5a83221e3ccb005246e8 
>   language/backgroundparser/backgroundparser.cpp ffe16e6102abb209ce2b935dd4acf6b225c46f2e 
>   language/codegen/applychangeswidget.cpp d339dfd2f7bdffd0b2340a766619c0a79b4bd317 
>   language/codegen/basicrefactoring.cpp fc559a018a1e82ba5795a454975b46277d45ca27 
>   language/codegen/codegenerator.cpp 56ddfcf17a430e65f3000008f2f9ff335243e974 
>   language/codegen/coderepresentation.cpp c868af68b7e27e2ac4006b42abf219718fefffd7 
>   language/codegen/templaterenderer.cpp 5fcacb004ee28d2af51a6a9f444c9362c8ab69c8 
>   language/duchain/navigation/abstractnavigationwidget.h 78a86d4305b92f609c0b26a0fd3be89b52a4d08e 
>   language/duchain/navigation/abstractnavigationwidget.cpp e3dcb2d6f36f76c71f212e9be66bc624bf6a75bb 
>   language/duchain/navigation/problemnavigationcontext.cpp 8f0d7c8d6860bbb8b61817a40b8119cf325c050b 
>   language/duchain/navigation/useswidget.cpp a13e3ef9725b4c378a2b71294ec82f0f3bb2bc26 
>   language/duchain/persistentsetmap.h 6a19a506503c18120a3530769659f7614ee3783c 
>   plugins/classbrowser/classbrowserplugin.cpp 67b0de6ed18489c237c479d8adda1d45ed9aed35 
>   plugins/contextbrowser/browsemanager.h 3957080d9818d493300c065c4a9ba9a69e2e38a9 
>   plugins/contextbrowser/browsemanager.cpp 94b3f1f57f1f81ce6b17fec85896a4c83c315fc7 
>   plugins/contextbrowser/contextbrowser.cpp a223a966ff3664254cf371a47e238c177e7b49c3 
>   plugins/contextbrowser/contextbrowserview.cpp b60ea33cd40a6546f06cab2ea4eab16d3f14a6ef 
>   plugins/documentswitcher/documentswitcherplugin.cpp 8a20764b4788e29ddbd479f420b1626a0243310e 
>   plugins/documentview/kdevdocumentview.cpp 3b0a242f23c9fa0d6cb84f1415f2f6724fffe1f2 
>   plugins/documentview/kdevdocumentviewplugin.h 5875aeebf0f14d5f69ff85a212f79d87c079888b 
>   plugins/documentview/settings/preferences.cpp d0444cf6dc40a5ccb11764e0434d0291b49338bd 
>   plugins/execute/executeplugin.cpp eea8c8ce0ce1d5d176db15e0d922885b1f77c118 
>   plugins/execute/nativeappconfig.cpp 9c83db9e021201b0732ce186423a3d922458262d 
>   plugins/execute/nativeappjob.cpp 9dc27b212444fb02e1839a592631c0c5374e39c9 
>   plugins/executescript/executescriptplugin.cpp 66d83ba41a866e75915535e98b5ef2c6cdc0d2ef 
>   plugins/executescript/scriptappconfig.cpp 947cc464a42e3c18c38034287c93bdcb4ae8726c 
>   plugins/executescript/scriptappjob.cpp cbf9d75482aa974cf9b30d4d30397d5fdcb6737b 
>   plugins/externalscript/editexternalscript.cpp 6c52b06636b8dd1a905e5905d21657e210231b0d 
>   plugins/externalscript/externalscriptview.cpp 5fe989cc84a90be5e7d3af9da2100701d67f038f 
>   plugins/filemanager/bookmarkhandler.h b05e5e6c91436224d8d3d9509a4f830386ebb55d 
>   plugins/filemanager/bookmarkhandler.cpp ad0cf316df363f113ff9288476ca3c93cedbd458 
>   plugins/filemanager/kdevfilemanagerplugin.cpp ba847cc75b6519c098c1d9736227f1515b48dc9c 
>   plugins/git/gitplugin.cpp a72fbfc41129748cfb21c8de03f068acb826e3e4 
>   plugins/git/stashmanagerdialog.cpp 1fb939409e5982ff65aee9ee89ee96985cf8ed86 
>   plugins/grepview/grepdialog.h d34f851154c1250da22c0847646bce26ed210ac0 
>   plugins/grepview/grepdialog.cpp 4671c30bcdb75699d0cd474da78cfbf15eadf535 
>   plugins/grepview/grepjob.h 369db264d2be2c4e80eb7fc332278a39844e61ee 
>   plugins/grepview/grepjob.cpp 719f5b76ba797432678e2d0a3c6ee0d0453dbd37 
>   plugins/grepview/grepviewplugin.cpp d20836846fb396f0ed2cc1c0262c73825efb4cd5 
>   plugins/konsole/kdevkonsoleview.cpp b2eb647318f40ac05ca8eb6f9360b678c4cafca4 
>   plugins/konsole/kdevkonsoleviewplugin.cpp 19b83dc0b548a5e7897e0f442c0113d056db8176 
>   plugins/openwith/openwithplugin.h 1ed2490978038e400e7a2da26002b874fb1ca90d 
>   plugins/openwith/openwithplugin.cpp a6338779b17d7c06d1fa464dbbd8b294eac20e6b 
>   plugins/pastebin/pastebinplugin.cpp 739874515f5e359d5707a275e788275003ef192c 
>   plugins/patchreview/CMakeLists.txt b8b5864667fee11a3ec69cc1939d2950f315ac88 
>   plugins/problemreporter/problemtreeview.cpp 2e890b5af9c9352d484aced1e971c7b841ea2c4e 
>   plugins/projectfilter/tests/CMakeLists.txt 608e84720f636d36ca934e2ac19599f2e5262b12 
>   plugins/projectmanagerview/CMakeLists.txt e534cb03b7d81ec2fe4362808a15e118313e381c 
>   plugins/projectmanagerview/projectmanagerview.h 2dab478f2e3acdfc5948d69ffadcbd15be1691a7 
>   plugins/projectmanagerview/projectmanagerview.cpp 95ae9a90273ec4f4be57fdc5e526e4416440788f 
>   plugins/projectmanagerview/projectmanagerviewplugin.cpp 595b99c461382854d47cb57b15debf983f281b92 
>   plugins/projectmanagerview/projectmodelsaver.h 51994d4a0997eb57aaad4f1da5dc978d5f012e5b 
>   plugins/projectmanagerview/projecttreeview.cpp dbd25ffd28f5a918e4e86bf806771db1c926f529 
>   plugins/quickopen/projectfilequickopen.cpp acf3500ce9f741baa97e337eb91c395662a2dcd2 
>   plugins/quickopen/tests/CMakeLists.txt 096be5c8673bcfccc0afbc5c3e8dadc38c929b08 
>   plugins/reviewboard/reviewboardjobs.h 667d83ffaaae3b3ac5dfb6e25764ca53fb3937cc 
>   plugins/reviewboard/reviewboardjobs.cpp c6ba158e870e1de14822c0d558a285f0517fbf58 
>   plugins/reviewboard/reviewboardplugin.cpp c501e37c62d1c620eb16d1165a1b59f3f200e93a 
>   plugins/reviewboard/reviewpatchdialog.cpp 4802653096fa5187cce819183d1f5d4445dc404e 
>   plugins/standardoutputview/outputwidget.h 1f00f053c8b594bc5deee62927fc4f18b24ccd13 
>   plugins/standardoutputview/outputwidget.cpp 50594b6c5efe32a924423f9b9480c2628ca799f4 
>   plugins/standardoutputview/standardoutputview.cpp d38d1af2395a3f2bf067d9c2062f4cdfbc8df151 
>   plugins/testview/testview.cpp d66612337cdce212c6e05cf29abe56c91c9e3ed9 
>   plugins/vcschangesview/vcschangesviewplugin.cpp 6d5a4f9367f362479b25fcf5be483a3e734166c9 
>   plugins/welcomepage/CMakeLists.txt 58d24a9c2cd01abc5e0629360b1f07debaf4b306 
>   project/builderjob.cpp ec78d1aa8bcc888f1f8286f1650092ff5e1bdfad 
>   project/helper.cpp e34b146966bc27f50380578b2bad873873f04870 
>   project/importprojectjob.h 0504981b32028ef2fd2dc869838a067f6ae41a04 
>   project/importprojectjob.cpp 2c8989adeddbf5a48bfa8dd1a0b873ffbef9daa1 
>   project/projectconfigskeleton.cpp 0720210c79afee6fd05e0f5ad326781755c19652 
>   project/projectitemlineedit.cpp 0c3447bee8ec6ca1755f87c0366276dbd015b0d4 
>   project/projectmodel.cpp 49cd984bdcbba661fedd8fbf42912b43fa28b733 
>   project/projectproxymodel.cpp 6b0a356bc0c90a63ad2f9761f38d70d3a097c3d4 
>   project/tests/projectmodelperformancetest.cpp b3dc3b1af656d0eae60ab3e45307768afba76d49 
>   serialization/itemrepository.h 1d9612aadbc78050de291172524a9bd7d2aa67a7 
>   shell/debugcontroller.cpp 6361476fd873e5e90fd5d1bc73770d0cf6a2741d 
>   shell/documentationcontroller.cpp 675eda976393b5a0829ca4d2b468a501cad481b3 
>   shell/documentcontroller.cpp 915bc2ac087633a02a47a30b899b9499edb97c2a 
>   shell/environmentconfigurebutton.cpp d0ce5ff231fb5cbbc746353ce0c274e859858f16 
>   shell/languagecontroller.cpp 7bc1a9bdc7dd3b2690e9908abf7919875b54550d 
>   shell/launchconfigurationdialog.h d092cbecec2ffe53b784cdb91c7aece15c976d11 
>   shell/launchconfigurationdialog.cpp 134ca9f1525a25cb2e2cdbfc0fcde83f72d85274 
>   shell/loadedpluginsdialog.cpp d977b6f8cb76279db1d55a94ac65bbd2761bf9d1 
>   shell/mainwindow.cpp 8757942cc5043a7a7afd5656fa850f419897a97c 
>   shell/mainwindow_actions.cpp 8196afa85f2688ada4204dc7ee3627cbb094e2b6 
>   shell/mainwindow_p.h 9cc4b235c2535496a17de6fe3a81b9d04c8d5fa7 
>   shell/mainwindow_p.cpp 516bc01ac92fbeb9a9ae541387b4103fe6dc433d 
>   shell/openprojectdialog.h 72200ebe6fa9020e4b95c5425c6e06b6f9bebd96 
>   shell/openprojectdialog.cpp 0d0ff619affdf904591789a38e801125412dbe9b 
>   shell/openprojectpage.cpp 40695c0bfdf8996c660ba7513b1bc7cade3092d4 
>   shell/partcontroller.h 72c1c472428a2cb8aa6ac6f1d22ebd5ef97ef7b4 
>   shell/partcontroller.cpp dae1b5e63e42770a041be79de883848f2a65b807 
>   shell/plugincontroller.cpp ad2b2afe9c479ca56500b2458eaac9e008493943 
>   shell/progresswidget/progressdialog.h 68eb56e0a6e62d3d31d1ef711a29bf06f6ca0ffc 
>   shell/progresswidget/progressdialog.cpp df210ebec1532a431b46e09d8494f7c3c05e5fb3 
>   shell/project.cpp 473efecf7ccc3159de28083079d8cb4065d94028 
>   shell/projectcontroller.h 062e20061e9cac88c4b6d0c62c9c71b4ffda2045 
>   shell/projectcontroller.cpp c8e89e872540fdce8f6e0db66ce66a492f14cf3d 
>   shell/projectsourcepage.cpp a5f53ca659c9aa0be96588dd7595a2cfffaf2145 
>   shell/runcontroller.h bdd2073a883cffd713d3c13377617c5e04770ffb 
>   shell/runcontroller.cpp e18d96b63009e3855f19997741749f7da9cbb4c1 
>   shell/sessionchooserdialog.cpp 23ad60b9396e8a3712eb62d7617f1c81cc782165 
>   shell/sessioncontroller.h 269a90a8d14b9ebf1c10ccb26fa57393aa189159 
>   shell/sessiondialog.cpp c7b8febb08ed41e660c80aa0c2028654fd9e02d4 
>   shell/settings/environmentwidget.cpp f91665bdf3fbbefc91bbe6f3c049e9db7480ccc6 
>   shell/settings/projectpreferences.cpp 46bacb2a509c2f66ef9348c274a380832a1a0127 
>   shell/sourceformattercontroller.cpp 44acf910281dded351a92324e58662e0ef2f97b2 
>   shell/tests/CMakeLists.txt 71b99a0bc98d37288adeb539eb4b44c38375daaa 
>   shell/textdocument.cpp 70aeb9b6e635419dd019bb8021c46e3c7a81dc37 
>   shell/uicontroller.cpp 2108ff2193aeca1f53f808a94d74d1b7d19bf08d 
>   shell/workingsets/workingset.cpp b2ed6c02d0eca7308b75844ff3d1fd379b78deb0 
>   shell/workingsets/workingsettoolbutton.cpp 9678e5566d732f1a23feaf38d54536d19da88261 
>   sublime/container.cpp 4444077efe28570f04c09605226327112034854b 
>   sublime/idealcontroller.cpp d87487100aec6e467db720732ae1b8603d6f291e 
>   sublime/idealdockwidget.cpp 1807e4b4bafba356cc4d8383bb44e02ab7545151 
>   sublime/mainwindow.h f2f109cf9415b925b4abc9746d702952a6f36767 
>   sublime/mainwindow.cpp 32ef797eec0a6d54b868615fddfb9be5ec4574ce 
>   sublime/mainwindow_p.cpp 981811b1010d722e5d2e46e2ef9b54bf8e40717a 
>   util/activetooltip.cpp 8b8de2dc8b2863588f9cef8f272ff6a4b5f4a782 
>   util/convenientfreelist.h 6c5e5b97b72ce4020573b2dc9f5538223fcd56bd 
>   util/duchainify/main.cpp 15cf495fadd095caa744caa9c5e31f14cf4c77f6 
>   util/environmentgrouplist.h b3f94419459257ef40cced8064644426588cb1a5 
>   util/environmentgrouplist.cpp eeb44c1dc92bd8e5a7602cdcd550a97e1666c0a8 
>   util/environmentselectionwidget.h bd05642244853dde37f6e906f8195112b8f09910 
>   util/environmentselectionwidget.cpp 58d29d2b0398c6c1212de51b14b61fe244b793e3 
>   util/executecompositejob.h 030a7d0e815ab94a9b643566fd63610bf63b75e6 
>   util/foregroundlock.cpp 1c6789514db651d1d544445784a21c53cbc5a27a 
>   vcs/dvcs/ui/dvcsimportmetadatawidget.cpp 152bd5c2485e86a1c60dd90f2677d112372faee6 
>   vcs/interfaces/ipatchsource.cpp 02b6324a9b4ded6feaa2c55f714162c969c6732e 
>   vcs/models/vcsfilechangesmodel.cpp be93ae041c5e5b271a281617d5918e4ee23e1234 
>   vcs/vcspluginhelper.cpp a82b7205c07119b2dd97c4126200d3256484c04d 
>   vcs/widgets/vcscommitdialog.cpp ecf53baab423656bfd6fd65767c289a61af08e4f 
>   vcs/widgets/vcsdiffpatchsources.h fb7cbfd8b67d79c88a37dc414e0a971e43c99147 
>   vcs/widgets/vcsdiffpatchsources.cpp 1dcae0e4c53a8257052ba8f50c1870fdc2606ca1 
>   vcs/widgets/vcsdiffwidget.cpp 79ecbf8d431303dbe3df74a59d33ee5ceb8e7ab7 
>   vcs/widgets/vcseventwidget.cpp ee7bb075a680846bce5ce995eba05e8db9706716 
> 
> Diff: https://git.reviewboard.kde.org/r/123158/diff/
> 
> 
> Testing
> -------
> 
> Compiles and seems to be working :)
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150328/7a03f25a/attachment-0001.html>